Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gap between sidebar boxes (for pages and events) #2090

Merged

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Feb 21, 2023

Short description

This PR removes the gap between the sidebar boxes for pages and events. The PR is similar to the one where I remove the gap for POIs.

Proposed changes

  • Switch from gap to flex for pages and events
  • Adjust the spacing to be 16px / 1rem for all boxes to all sides

Side effects

I think none

Resolved issues

Fixes: #2032


Pull Request Review Guidelines

@JoeyStk JoeyStk requested a review from a team as a code owner February 21, 2023 11:40
@codeclimate
Copy link

codeclimate bot commented Feb 21, 2023

Code Climate has analyzed commit 81fb808 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.3% (0.0% change).

View more on Code Climate.

@JoeyStk JoeyStk force-pushed the enhancement/remove_gap_between_sidebar_boxes_for_pages branch from 66f0792 to 4765a6f Compare February 21, 2023 11:41
Copy link
Contributor

@seluianova seluianova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JoeyStk JoeyStk force-pushed the enhancement/remove_gap_between_sidebar_boxes_for_pages branch 2 times, most recently from e177000 to 258d7af Compare February 27, 2023 12:55
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 🎉

@JoeyStk JoeyStk force-pushed the enhancement/remove_gap_between_sidebar_boxes_for_pages branch from 258d7af to 81fb808 Compare February 28, 2023 14:04
@JoeyStk JoeyStk merged commit 4dad02a into develop Feb 28, 2023
@JoeyStk JoeyStk deleted the enhancement/remove_gap_between_sidebar_boxes_for_pages branch February 28, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gap in sidebar when boxes are collapsed
3 participants