Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when cloning a region without imprint #2154

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

timobrembeck
Copy link
Member

Short description

Fix error when cloning a region without imprint

Proposed changes

  • Only duplicate imprint when it exists

Resolved issues

Fixes: #2153


Pull Request Review Guidelines

@codeclimate
Copy link

codeclimate bot commented Mar 23, 2023

Code Climate has analyzed commit b243d03 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.8% (0.0% change).

View more on Code Climate.

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works as expected 👍

@JoeyStk JoeyStk self-requested a review March 24, 2023 09:29
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 🎉

@timobrembeck timobrembeck merged commit ce2453e into develop Mar 24, 2023
@timobrembeck timobrembeck deleted the bugfix/clone-region-without-imprint branch March 24, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError when cloning region without imprint
3 participants