Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation status for outdated mts #2157

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Mar 24, 2023

Short description

The translation status for machine translations used to still show the bot icon even when the translation wasn't up-to-date anymore. This PR fixes this and only shows the bot icon for machine translations that are up-to-date and shows the warning icon for machine translations that are outdated.

Proposed changes

  • Adds distinction between up-to-date and outdated machine translations and decides for the correct translation status and icon

Side effects

  • I restricted the query for machine translations and this could cause some side effects, although I don't have an exact idea how this might show

Resolved issues

Fixes: #2137


Pull Request Review Guidelines

@JoeyStk JoeyStk requested a review from a team as a code owner March 24, 2023 11:17
@JoeyStk JoeyStk force-pushed the bufix/fix_translation_status_for_outdated_mt branch from c08af1e to 2c94086 Compare March 24, 2023 11:20
@codeclimate
Copy link

codeclimate bot commented Mar 24, 2023

Code Climate has analyzed commit 97617ef and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.1% (0.0% change).

View more on Code Climate.

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this seems to fix the issue, but I have one small suggestion for an improvement :)

integreat_cms/cms/models/abstract_content_translation.py Outdated Show resolved Hide resolved
@JoeyStk JoeyStk force-pushed the bufix/fix_translation_status_for_outdated_mt branch 2 times, most recently from c9f622f to ff17068 Compare March 26, 2023 15:11
@JoeyStk JoeyStk force-pushed the bufix/fix_translation_status_for_outdated_mt branch from 2d23ccb to 97617ef Compare March 26, 2023 16:14
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@JoeyStk JoeyStk merged commit d5e996f into develop Mar 26, 2023
@JoeyStk JoeyStk deleted the bufix/fix_translation_status_for_outdated_mt branch March 26, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated machine translations not marked as outdated
3 participants