-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translation status for outdated mts #2157
Conversation
c08af1e
to
2c94086
Compare
Code Climate has analyzed commit 97617ef and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 76.1% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this seems to fix the issue, but I have one small suggestion for an improvement :)
c9f622f
to
ff17068
Compare
2d23ccb
to
97617ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Short description
The translation status for machine translations used to still show the bot icon even when the translation wasn't up-to-date anymore. This PR fixes this and only shows the bot icon for machine translations that are up-to-date and shows the warning icon for machine translations that are outdated.
Proposed changes
Side effects
Resolved issues
Fixes: #2137
Pull Request Review Guidelines