-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release notes number of #2137 #2165
Conversation
Code Climate has analyzed commit b9de63d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 76.1% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you a lot for the quick fix again
The issue with the wrong issue number is fixed. I have a question about the new implementation for the release note script. I tried to create the release notes for #2133 (just for testing). However I received an error message (see below).
I also got this error message for the two other release notes I tried to create
@JoeyStk Ah good point, I forgot to add a check whether the dependency jq is installed (jq is a json parser for the command line). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, now it works! Thank you very much.
And once again I'm sorry, this time for the wrong issue folder 🙈
No more merges on a weekend for me
Haha, no problem, I mean we missed it in the review as well 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, seems to work as expected 👍
Short description
It seems the new tool does not prevent all errors in the release notes...
Any suggestions how we could make sure that the correct number is referenced?
Maybe a check that each release note of a PR is also mentioned in the PR description?
Pull Request Review Guidelines