Change 'last updated' field in region list to refer to their content #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 94bb980 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 76.6% (0.0% change). View more on Code Climate. |
timobrembeck
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Thanks! 👍
Apart from @david-venhoff's comments, I don't have any further objections, except maybe adding a changelog entry for it 😅
charludo
force-pushed
the
feature/last-updated-refers-to-region-content
branch
from
2b5bcdd
to
6fd7397
Compare
charludo
force-pushed
the
feature/last-updated-refers-to-region-content
branch
from
6fd7397
to
94bb980
Compare
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Change 'last updated' field in region list to each region's content instead of the region object itself.
Proposed changes
last_content_updatecached property to region modellast_updatedin the region listSide effects
last_updatedfield unmodified should prevent any backwards compatibility issuesResolved issues
Fixes: #1836
Pull Request Review Guidelines