Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix different HIX value calculation #2439

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

seluianova
Copy link
Contributor

Short description

There are still cases where we got different HIX values for the same content.
For example:

  1. Create new page with the following content:
<p>Eine sehr schwierige Zeile</p>
<p>Eine weitere sehr schwierige Zeile</p>
  1. Save or Publish it --> HIX is 19.17
  2. Press "Publish" again with no changes --> HIX is 19.86

The behavior will be the same if step 3 is "Press Ctrl+A and reload the HIX value".

Proposed changes

  • Rework text normalization before sending request to Textlab API

Side effects

  • Hope none, but careful testing is welcomed

Resolved issues

Fixes: #2224


Pull Request Review Guidelines

@seluianova seluianova requested a review from a team as a code owner October 2, 2023 20:10
@seluianova seluianova linked an issue Oct 2, 2023 that may be closed by this pull request
@codeclimate
Copy link

codeclimate bot commented Oct 2, 2023

Code Climate has analyzed commit 1046c4c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 11.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.5% (0.0% change).

View more on Code Climate.

Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you

Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@seluianova seluianova merged commit f0b2882 into develop Oct 9, 2023
5 checks passed
@seluianova seluianova deleted the bugfix/hix-value-diff branch October 9, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIX value differs when calculated via tinymce vs pre save signal
3 participants