Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in location coordinates retrieving #2529

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

MizukiTemma
Copy link
Member

Short description

This PR fixes TypeError: expected string or bytes-like object, which occurs in an edge case where only spaces are given as address and house number.

Proposed changes

  • Check whether the input for "addess and house number" contains any valid letter

Side effects

  • There may be other edge cases 馃

Resolved issues

Fixes: #2495


Pull Request Review Guidelines

@MizukiTemma MizukiTemma requested a review from a team as a code owner November 5, 2023 19:26
Copy link

codeclimate bot commented Nov 5, 2023

Code Climate has analyzed commit 177d169 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.8% (0.0% change).

View more on Code Climate.

@MizukiTemma MizukiTemma force-pushed the bug/error_in_coordinates_retrieving branch from 020adcf to adafc97 Compare November 5, 2023 19:27
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 馃檹

Co-authored-by: Timo Brembeck <timo.brembeck@tuerantuer.org>
@MizukiTemma MizukiTemma force-pushed the bug/error_in_coordinates_retrieving branch from c638989 to 177d169 Compare November 5, 2023 19:50
@MizukiTemma MizukiTemma merged commit f7db2a8 into develop Nov 6, 2023
5 checks passed
@MizukiTemma MizukiTemma deleted the bug/error_in_coordinates_retrieving branch November 6, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: expected string or bytes-like object in nominatim API client
3 participants