Improve performance when deleting regions #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit supresses most linkcheck deletion listeners when deleting regions. This improves the performance a lot and the inconsistent db will be fixed when the findlinks command runs next.
|
Code Climate has analyzed commit daeb435 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 79.0% (0.0% change). View more on Code Climate. |
MizukiTemma
approved these changes
Nov 20, 2023
charludo
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr suppresses most linkcheck deletion listeners when deleting regions, which hopefully improves performance enough that deleting big regions will be possible again.
Currently the
Linkpost_delete handlers from linkcheck will still run, which is unnecessary. However this is hopefully not a big problem, since those only run per link and not per page translation.Proposed changes
disable_listenerscontext managerSide effects
findlinksmanagement command.Resolved issues
fixes: #2336
Pull Request Review Guidelines