Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HIX value difference #2630

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix HIX value difference #2630

merged 1 commit into from
Feb 5, 2024

Conversation

seluianova
Copy link
Contributor

@seluianova seluianova commented Feb 2, 2024 •
edited

Short description

Fix another portion of cases with HIX value difference problem:

  1. Adding an empty paragraph to a 1-paragraph text increased the HIX value
  2. Adding empty headers increased the HIX value
  3. Adding images increased the HIX value

Proposed changes

  • refactoring of the normalize_text function

Side effects

No?

Resolved issues

In follow-up to #2577

Pull Request Review Guidelines

@seluianova seluianova requested a review from a team as a code owner February 2, 2024 18:02
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 2, 2024 •
edited

Code Climate has analyzed commit c867fd6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.0% (0.0% change).

View more on Code Climate.

@JoeyStk JoeyStk mentioned this pull request Feb 5, 2024
Merged
JoeyStk
JoeyStk approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this fix. I wasn't able to change the HIX value in unwanted ways anymore. I also like your code style. I only I had one idea for the release note :)

integreat_cms/release_notes/current/unreleased/2630.yml Outdated Show resolved Hide resolved
@MizukiTemma MizukiTemma self-requested a review February 5, 2024 12:08
MizukiTemma
MizukiTemma approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😸 Thank you 👍

@seluianova seluianova merged commit 9916ac8 into develop Feb 5, 2024
5 checks passed
@seluianova seluianova deleted the bugfix/hix-value-difference branch February 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeyStk JoeyStk JoeyStk approved these changes

@MizukiTemma MizukiTemma MizukiTemma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seluianova @JoeyStk @MizukiTemma