Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feedback list layout #2664

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix feedback list layout #2664

merged 1 commit into from
Feb 21, 2024

Conversation

seluianova
Copy link
Contributor

@seluianova seluianova commented Feb 19, 2024

Short description

Fix white space to the right of feedback form at certain screen resolution/window size:
image

Proposed changes

  • rework of html templates for feedback forms
  • add additional templates for table rows to remove duplication between archived / non-archived feedback

Side effects

No?

Resolved issues

Fixes: #2609


Pull Request Review Guidelines

@seluianova seluianova requested a review from a team as a code owner February 19, 2024 12:14
Copy link

codeclimate bot commented Feb 19, 2024

Code Climate has analyzed commit 1b20d18 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.1% (0.0% change).

View more on Code Climate.

Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😸

Copy link
Contributor

@sarahsporck sarahsporck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Looks like charm now ⭐

@seluianova seluianova merged commit 885d757 into develop Feb 21, 2024
5 checks passed
@seluianova seluianova deleted the bugfix/feedback-table-style-2 branch February 21, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The table with list of feedback extends beyond the page
3 participants