Fix behavior when cloning region with page based offers

[charludo]

Short description

Currently, cloning a region which has embedded offfers into pages can lead to unexpected errors when the newly-created region does not have the same offers enabled.

Proposed changes

• allow users to choose from two behaviors when cloning a region: either force-activate all required offers* or discard embeddings for missing offers when cloning pages.
• * small caveat: if no Zammad URL is provided for the new region, Zammad embeddings are discarded even when force-activation is selected

Side effects

• none that I could find. As far as I can tell, results are correct in all cases (no cloning, cloning with force-activation or discarding, with/without Zammad URL)

Resolved issues

Fixes: #2665

---

Pull Request Review Guidelines

[charludo]

One test i failing becuase the valid link count is somehow higher now after duplicating a region - I don't really know why, does someone have an idea?

[david-venhoff]

One test i failing becuase the valid link count is somehow higher now after duplicating a region - I don't really know why, does someone have an idea?

With this pr the following link is classified as valid: https://integreat.app/cloned/de/offers, while it is classified as invalid on develop.
We have some logic that checks internal links without doing network requests to those and in this case it verifies that the region cloned exists and has offers

integreat-cms/integreat_cms/cms/utils/internal_link_checker.py

Line 142 in 1d841af

if not region.offers.exists():

I assume that is now the case with this pr, while it had no offers before, which causes it to mark the link as valid...

So the simple fix to just update the expected numbers should be fine I think.

[codeclimate]

Code Climate has analyzed commit 12c48c6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 88.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.7% (0.0% change).

View more on Code Climate.

[david-venhoff]

LGTM

[MizukiTemma]

Thank you 👍 works as expected!

[david-venhoff]

🎉