Change public upload, fixes INFRA-205 #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timoludwig @lukasboehm97 do you have time for a quick review? Otherwise I'd deploy the change myself. As the influence on the rest of the functionality is rather limited that should be acceptable. |
timobrembeck
reviewed
Jun 1, 2022
There was a problem hiding this comment.
Thanks a lot 👍
In general it seems to work, I just found a problem when the discipline is changed multiple times.
Also, I noticed that the logo image path is broken on the current develop branch, could you add {% load static %} to the top of the template file and replace this line:
with
<link rel="icon" href="{% static 'images/logo.svg' %}">
and this line:
with
<img class="mb-4" src="{% static 'images/logo.svg' %}" alt="" width="72" height="72">
as well as add a changelog entry for this?
svenseeberg
force-pushed
the
feature/public-upload-reduced
branch
2 times, most recently
from
8c892d1
to
173d33a
Compare
timobrembeck
reviewed
Jun 1, 2022
* Directly show documents when selecting a module. * Fix static files.
svenseeberg
force-pushed
the
feature/public-upload-reduced
branch
from
173d33a
to
f201829
Compare
Definitely. I did not notice that there now is a changelog :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
As we now have many photos in our content management system, the list of missing images per training set is rather short. This makes it cumbersome to go through all disciplines and training sets to find and upload missing images.
Proposed changes
When selecting a discipline, we now directly show associated documents. This skips the step of selecting a training set.
Resolved issues
Fixes: INFRA-205