Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Bump org.eclipse.jetty.version from 9.4.27.v20200227 to 9.4.34.v20201102 #148

Closed
wants to merge 1 commit into from
Closed

[Security] Bump org.eclipse.jetty.version from 9.4.27.v20200227 to 9.4.34.v20201102 #148

wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps org.eclipse.jetty.version from 9.4.27.v20200227 to 9.4.34.v20201102.
Updates jetty-webapp from 9.4.27.v20200227 to 9.4.34.v20201102 This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Local Temp Directory Hijacking Vulnerability

Impact

On Unix like systems, the system's temporary directory is shared between all users on that system. A collocated user can observe the process of creating a temporary sub directory in the shared temporary directory and race to complete the creation of the temporary subdirectory. If the attacker wins the race then they will have read and write permission to the subdirectory used to unpack web applications, including their WEB-INF/lib jar files and JSP files. If any code is ever executed out of this temporary directory, this can lead to a local privilege escalation vulnerability.

Additionally, any user code uses of WebAppContext::getTempDirectory would similarly be vulnerable.

Additionally, any user application code using the ServletContext attribute for the tempdir will also be impacted. See: https://javaee.github.io/javaee-spec/javadocs/javax/servlet/ServletContext.html#TEMPDIR

For example:

import java.io.File;
import java.io.IOException;
import javax.servlet.ServletContext;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
public class ExampleServlet extends HttpServlet {
@Override
</tr></table> ... (truncated)
Affected versions: < 9.4.33

Release notes

Sourced from jetty-webapp's releases.

9.4.33.v20201020

Changes

  • #5022 : Cleanup ServletHandler, specifically with respect to making filter chains more extensible
  • #5368 : WebSocket text event execute in same thread as running binary event and destroy Threadlocal
  • #5378 : Filter/Servlet/Listener Holders are not started if added during STARTING state.
  • #5409 : HttpClient fails intermittently with "Invalid response state TRANSIENT"
  • #5417 : Badly configured HttpConfiguration.securePort can lead to wrong port produced by ForwardedHeader
  • #5443 : Request without Host header fails with NullPointerException in ForwardedRequestCustomizer
  • #5451 : Improve Working Directory creation
  • #5454 : Request error context is not reset
  • #5475 : Update to spifly 1.3.2 and asm 9
  • #5480 : NPE from WebInfConfiguration.deconfigure during WebAppContext shutdown

9.4.32.v20200930

Changelog

  • #2796 : HTTP/2 max local stream count exceeded when request fails
  • #3766 : Introduce HTTP/2 API to batch frames
  • #3916 : multipart/byterange output is invalid to RFC7233
  • #4809 : Set a max number of requests per connection
  • #4824 : WebSocket server outgoing message queue memory growth
  • #4888 : Request getSession() method throws IllegalStateException when Session exists
  • #4954 : Simplify ability to get Byte Counts about requests
  • #5032 : Introduce Listeners to aid in tracking timings within ServletContext and WebApp
  • #5079 : :authority header for IPv6 address in HTTP/2 not having square brackets
  • #5103 : Proxy sets protocol version to 2.0 instead of 1.1 when accessed from H2 client
  • #5104 : AbstractProxyServlet include incorrect protocol version in Via header when accessed over H2
  • #5105 : Graceful shutdown does not wait for resumed requests
  • #5108 : Improve SessionTracker scalability
  • #5121 : Add if (LOG.isDebugEnabled()) in CompressExtension.decompress
  • #5122 : Retrieving websocket connections via jmx
  • #5129 : No jars added when using a folder in extraClasspath of the webapp context xml file
  • #5147 : Set MaxUsageCount with existing connection pool changing the behavior
  • #5150 : Zero connection timeout is not supported in HTTP client with non-blocking connect
  • #5152 : HttpClient should handle unsolicited responses
  • #5162 : DecoratingListener raises a NullPointerException
  • #5165 : Wrong messagesIn count for HttpClient
  • #5170 : NullPointerException in HttpReceiverOverHTTP during WebSocket client Upgrade
  • #5185 : Introduce DoSFilter Listener for Alert messages
  • #5193 : WebSocket unimplemented BINARY message handling can result in TEXT message delivery to fail
  • #5201 : QueuedThreadPool setDetailedDump gives less detail
  • #5204 : SNI does not work with PKIX
  • #5214 : Servlet HEAD doesn't support content-length over Integer.MAX_VALUE
  • #5217 : Review RoundRobinConnectionPool
  • #5224 : HttpServletRequest.getServerName can include port when using ForwardedRequestCustomizer
  • #5233 : Bad/Unsupported HTTP version should return 505 not 400
  • #5246 : GzipHandler's DeflaterPool should be dumpable
  • #5247 : Improve ForwardRequestCustomizer authority priority
  • #5268 : WARN Ignoring eviction setting: 0
Commits

Updates jetty-annotations from 9.4.27.v20200227 to 9.4.34.v20201102

Release notes

Sourced from jetty-annotations's releases.

9.4.33.v20201020

Changes

  • #5022 : Cleanup ServletHandler, specifically with respect to making filter chains more extensible
  • #5368 : WebSocket text event execute in same thread as running binary event and destroy Threadlocal
  • #5378 : Filter/Servlet/Listener Holders are not started if added during STARTING state.
  • #5409 : HttpClient fails intermittently with "Invalid response state TRANSIENT"
  • #5417 : Badly configured HttpConfiguration.securePort can lead to wrong port produced by ForwardedHeader
  • #5443 : Request without Host header fails with NullPointerException in ForwardedRequestCustomizer
  • #5451 : Improve Working Directory creation
  • #5454 : Request error context is not reset
  • #5475 : Update to spifly 1.3.2 and asm 9
  • #5480 : NPE from WebInfConfiguration.deconfigure during WebAppContext shutdown

9.4.32.v20200930

Changelog

  • #2796 : HTTP/2 max local stream count exceeded when request fails
  • #3766 : Introduce HTTP/2 API to batch frames
  • #3916 : multipart/byterange output is invalid to RFC7233
  • #4809 : Set a max number of requests per connection
  • #4824 : WebSocket server outgoing message queue memory growth
  • #4888 : Request getSession() method throws IllegalStateException when Session exists
  • #4954 : Simplify ability to get Byte Counts about requests
  • #5032 : Introduce Listeners to aid in tracking timings within ServletContext and WebApp
  • #5079 : :authority header for IPv6 address in HTTP/2 not having square brackets
  • #5103 : Proxy sets protocol version to 2.0 instead of 1.1 when accessed from H2 client
  • #5104 : AbstractProxyServlet include incorrect protocol version in Via header when accessed over H2
  • #5105 : Graceful shutdown does not wait for resumed requests
  • #5108 : Improve SessionTracker scalability
  • #5121 : Add if (LOG.isDebugEnabled()) in CompressExtension.decompress
  • #5122 : Retrieving websocket connections via jmx
  • #5129 : No jars added when using a folder in extraClasspath of the webapp context xml file
  • #5147 : Set MaxUsageCount with existing connection pool changing the behavior
  • #5150 : Zero connection timeout is not supported in HTTP client with non-blocking connect
  • #5152 : HttpClient should handle unsolicited responses
  • #5162 : DecoratingListener raises a NullPointerException
  • #5165 : Wrong messagesIn count for HttpClient
  • #5170 : NullPointerException in HttpReceiverOverHTTP during WebSocket client Upgrade
  • #5185 : Introduce DoSFilter Listener for Alert messages
  • #5193 : WebSocket unimplemented BINARY message handling can result in TEXT message delivery to fail
  • #5201 : QueuedThreadPool setDetailedDump gives less detail
  • #5204 : SNI does not work with PKIX
  • #5214 : Servlet HEAD doesn't support content-length over Integer.MAX_VALUE
  • #5217 : Review RoundRobinConnectionPool
  • #5224 : HttpServletRequest.getServerName can include port when using ForwardedRequestCustomizer
  • #5233 : Bad/Unsupported HTTP version should return 505 not 400
  • #5246 : GzipHandler's DeflaterPool should be dumpable
  • #5247 : Improve ForwardRequestCustomizer authority priority
  • #5268 : WARN Ignoring eviction setting: 0
Commits

Updates websocket-server from 9.4.27.v20200227 to 9.4.34.v20201102

Updates jetty-maven-plugin from 9.4.27.v20200227 to 9.4.34.v20201102

Release notes

Sourced from jetty-maven-plugin's releases.

9.4.33.v20201020

Changes

  • #5022 : Cleanup ServletHandler, specifically with respect to making filter chains more extensible
  • #5368 : WebSocket text event execute in same thread as running binary event and destroy Threadlocal
  • #5378 : Filter/Servlet/Listener Holders are not started if added during STARTING state.
  • #5409 : HttpClient fails intermittently with "Invalid response state TRANSIENT"
  • #5417 : Badly configured HttpConfiguration.securePort can lead to wrong port produced by ForwardedHeader
  • #5443 : Request without Host header fails with NullPointerException in ForwardedRequestCustomizer
  • #5451 : Improve Working Directory creation
  • #5454 : Request error context is not reset
  • #5475 : Update to spifly 1.3.2 and asm 9
  • #5480 : NPE from WebInfConfiguration.deconfigure during WebAppContext shutdown

9.4.32.v20200930

Changelog

  • #2796 : HTTP/2 max local stream count exceeded when request fails
  • #3766 : Introduce HTTP/2 API to batch frames
  • #3916 : multipart/byterange output is invalid to RFC7233
  • #4809 : Set a max number of requests per connection
  • #4824 : WebSocket server outgoing message queue memory growth
  • #4888 : Request getSession() method throws IllegalStateException when Session exists
  • #4954 : Simplify ability to get Byte Counts about requests
  • #5032 : Introduce Listeners to aid in tracking timings within ServletContext and WebApp
  • #5079 : :authority header for IPv6 address in HTTP/2 not having square brackets
  • #5103 : Proxy sets protocol version to 2.0 instead of 1.1 when accessed from H2 client
  • #5104 : AbstractProxyServlet include incorrect protocol version in Via header when accessed over H2
  • #5105 : Graceful shutdown does not wait for resumed requests
  • #5108 : Improve SessionTracker scalability
  • #5121 : Add if (LOG.isDebugEnabled()) in CompressExtension.decompress
  • #5122 : Retrieving websocket connections via jmx
  • #5129 : No jars added when using a folder in extraClasspath of the webapp context xml file
  • #5147 : Set MaxUsageCount with existing connection pool changing the behavior
  • #5150 : Zero connection timeout is not supported in HTTP client with non-blocking connect
  • #5152 : HttpClient should handle unsolicited responses
  • #5162 : DecoratingListener raises a NullPointerException
  • #5165 : Wrong messagesIn count for HttpClient
  • #5170 : NullPointerException in HttpReceiverOverHTTP during WebSocket client Upgrade
  • #5185 : Introduce DoSFilter Listener for Alert messages
  • #5193 : WebSocket unimplemented BINARY message handling can result in TEXT message delivery to fail
  • #5201 : QueuedThreadPool setDetailedDump gives less detail
  • #5204 : SNI does not work with PKIX
  • #5214 : Servlet HEAD doesn't support content-length over Integer.MAX_VALUE
  • #5217 : Review RoundRobinConnectionPool
  • #5224 : HttpServletRequest.getServerName can include port when using ForwardedRequestCustomizer
  • #5233 : Bad/Unsupported HTTP version should return 505 not 400
  • #5246 : GzipHandler's DeflaterPool should be dumpable
  • #5247 : Improve ForwardRequestCustomizer authority priority
  • #5268 : WARN Ignoring eviction setting: 0
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
[Security] Bump org.eclipse.jetty.version
58a7ea5 
Bumps `org.eclipse.jetty.version` from 9.4.27.v20200227 to 9.4.34.v20201102.

Updates `jetty-webapp` from 9.4.27.v20200227 to 9.4.34.v20201102
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](jetty/jetty.project@jetty-9.4.27.v20200227...jetty-9.4.34.v20201102)

Updates `jetty-annotations` from 9.4.27.v20200227 to 9.4.34.v20201102
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](jetty/jetty.project@jetty-9.4.27.v20200227...jetty-9.4.34.v20201102)

Updates `websocket-server` from 9.4.27.v20200227 to 9.4.34.v20201102

Updates `jetty-maven-plugin` from 9.4.27.v20200227 to 9.4.34.v20201102
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](jetty/jetty.project@jetty-9.4.27.v20200227...jetty-9.4.34.v20201102)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Nov 4, 2020
@coveralls
Copy link

coveralls commented Nov 4, 2020 •
edited

Coverage Status

Coverage remained the same at 65.417% when pulling 58a7ea5 on dependabot/maven/org.eclipse.jetty.version-9.4.34.v20201102 into 25edc20 on master.

@syjer
Copy link
Member

syjer commented Nov 10, 2020 •
edited

updated manually, closing this PR.

@syjer syjer closed this Nov 10, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/maven/org.eclipse.jetty.version-9.4.34.v20201102 branch November 10, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coveralls @syjer