Bugfix: kubernetes login creates too many tokens #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digiserg
force-pushed
the
bugfix/vaultLogin
branch
from
a2e9ce2
to
3b0d484
Compare
rgooding
reviewed
Mar 2, 2022
rgooding
reviewed
Mar 2, 2022
digiserg
force-pushed
the
bugfix/vaultLogin
branch
from
3b0d484
to
d8f9fec
Compare
rgooding
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variables VAULT_AUTH_METHOD conflicts with the underlying
valslibrary and we were doing login all the time instead of login once and renewing the token when its about to expire.