Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParseError objects should contain information about the original entry #27

Closed
dwhieb opened this issue Mar 22, 2021 · 0 comments · Fixed by #29
Closed

ParseError objects should contain information about the original entry #27

dwhieb opened this issue Mar 22, 2021 · 0 comments · Fixed by #29
Assignees
@dwhieb
Labels
enhancement New feature or request

Comments

@dwhieb
Copy link
Member

dwhieb commented Mar 22, 2021

When a ParseError object is output, it's difficult to determine which entry the object corresponds to. Include a lines property on the ParseError object which contains an array of the lines that the library attempted to parse.
@dwhieb dwhieb added the enhancement New feature or request label Mar 22, 2021
@dwhieb dwhieb mentioned this issue Mar 22, 2021
Merged
@dwhieb dwhieb self-assigned this Mar 22, 2021
dwhieb added a commit that referenced this issue Mar 22, 2021
@dwhieb
NEW: include line data in ParseError objects (#27)
28fd71d 
closes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwhieb dwhieb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NEW: include line data in ParseError objects digitallinguistics/toolbox2json
1 participant
@dwhieb