Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not return a stream #34

Closed
dwhieb opened this issue Apr 10, 2021 · 0 comments · Fixed by #35
Closed

do not return a stream #34

dwhieb opened this issue Apr 10, 2021 · 0 comments · Fixed by #35
Assignees
@dwhieb
Labels
enhancement New feature or request

Comments

@dwhieb
Copy link
Member

dwhieb commented Apr 10, 2021

Use a stream to read the file, but return a Promise that resolves to an Array of the entries.
@dwhieb dwhieb self-assigned this Apr 10, 2021
@dwhieb dwhieb added the enhancement New feature or request label Apr 10, 2021
@dwhieb dwhieb mentioned this issue Apr 10, 2021
Merged
dwhieb added a commit that referenced this issue Apr 10, 2021
@dwhieb
v2.0
5f2f6a8 
closes #19
closes #21
closes #22
closes #23 (no longer relevant)
closes #24
closes #33 (no longer relevant)
closes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwhieb dwhieb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.0 digitallinguistics/toolbox2json
1 participant
@dwhieb