Added unit test and fix in the constructor making the test pass

digitalloggers · Jun 12, 2013 · 05c7f43 · 05c7f43
1 parent 87003ae
commit 05c7f43
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/lib/xml2js.js b/lib/xml2js.js
diff --git a/src/xml2js.coffee b/src/xml2js.coffee
@@ -61,6 +61,8 @@ class exports.ValidationError extends Error
 
 class exports.Parser extends events.EventEmitter
   constructor: (opts) ->
+    # if this was called without 'new', create an instance with new and return
+    return new exports.Parser opts unless @ instanceof exports.Parser
     # copy this versions default options
     @options = {}
     @options[key] = value for own key, value of exports.defaults["0.2"]

diff --git a/test/xml2js.test.coffee b/test/xml2js.test.coffee
@@ -308,3 +308,14 @@ module.exports =
     xml2js.parseString html, strict: false, (err, parsed) ->
       equ err, null
       test.finish()
+
+  'test construction with new and without': (test) ->
+    demo = '<xml><foo>Bar</foo></xml>'
+    withNew = new xml2js.Parser
+    withNew.parseString demo, (err, resWithNew) ->
+      equ err, undefined
+      withoutNew = xml2js.Parser()
+      withoutNew.parseString demo, (err, resWithoutNew) ->
+        equ err, undefined
+        assert.deepEqual resWithNew, resWithoutNew
+        test.done()