Skip to content

Commit

Permalink
Support adding values to a enum in the auto-migration
Browse files Browse the repository at this point in the history
  • Loading branch information
mpscholten committed Oct 19, 2021
1 parent 68780a6 commit 7f34cac
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 7 deletions.
13 changes: 6 additions & 7 deletions IHP/IDE/SchemaDesigner/Controller/EnumValues.hs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ import IHP.IDE.SchemaDesigner.View.Layout (findStatementByName, replace, schemaD
import IHP.IDE.SchemaDesigner.Controller.Helper
import IHP.IDE.SchemaDesigner.Controller.Validation

import qualified IHP.IDE.SchemaDesigner.SchemaOperations as SchemaOperations
import qualified IHP.IDE.SchemaDesigner.MigrationChangeTracker as MigrationChangeTracker

instance Controller EnumValuesController where
beforeAction = setLayout schemaDesignerLayout

Expand All @@ -26,8 +29,9 @@ instance Controller EnumValuesController where
case validationResult of
Failure message ->
setErrorMessage message
Success ->
updateSchema (map (addValueToEnum enumName enumValueName))
Success -> do
updateSchema $ SchemaOperations.addValueToEnum enumName enumValueName
MigrationChangeTracker.addValueToEnum enumName enumValueName

-- The form to save an enum has two save buttons:
--
Expand Down Expand Up @@ -70,11 +74,6 @@ instance Controller EnumValuesController where
updateSchema (map (deleteValueInEnum enumName valueId))
redirectTo ShowEnumAction { .. }

addValueToEnum :: Text -> Text -> Statement -> Statement
addValueToEnum enumName enumValueName (table@CreateEnumType { name, values }) | name == enumName =
table { values = values <> [enumValueName] }
addValueToEnum enumName enumValueName statement = statement

updateValueInEnum :: Text -> Text -> Int -> Statement -> Statement
updateValueInEnum enumName value valueId (table@CreateEnumType { name, values }) | name == enumName =
table { values = (replace valueId value values) }
Expand Down
2 changes: 2 additions & 0 deletions IHP/IDE/SchemaDesigner/Controller/Enums.hs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import IHP.IDE.SchemaDesigner.Controller.Helper
import IHP.IDE.SchemaDesigner.Controller.Validation

import qualified IHP.IDE.SchemaDesigner.SchemaOperations as SchemaOperations
import qualified IHP.IDE.SchemaDesigner.MigrationChangeTracker as MigrationChangeTracker

instance Controller EnumsController where
beforeAction = setLayout schemaDesignerLayout
Expand All @@ -36,6 +37,7 @@ instance Controller EnumsController where
redirectTo TablesAction
Success -> do
updateSchema $ SchemaOperations.addEnum enumName
MigrationChangeTracker.addEnum enumName
redirectTo ShowEnumAction { .. }

action EditEnumAction { .. } = do
Expand Down
6 changes: 6 additions & 0 deletions IHP/IDE/SchemaDesigner/MigrationChangeTracker.hs
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ doesTableExists tableName statements =
|> null
|> not

addEnum :: Text -> IO ()
addEnum enumName = withUnmigratedChanges $ SchemaOperations.addEnum enumName

addValueToEnum :: Text -> Text -> IO ()
addValueToEnum enumName enumValueName = withUnmigratedChanges $ SchemaOperations.addValueToEnum enumName enumValueName

ensureMigrationDirectory :: IO ()
ensureMigrationDirectory = Directory.createDirectoryIfMissing False "Application/Migration"

Expand Down
6 changes: 6 additions & 0 deletions IHP/IDE/SchemaDesigner/SchemaOperations.hs
Original file line number Diff line number Diff line change
Expand Up @@ -131,4 +131,10 @@ addEnum enumName statements = a <> enum <> b
findInsertionIndex (x:xs) !i = i
findInsertionIndex [] !i = i

addValueToEnum :: Text -> Text -> Schema -> Schema
addValueToEnum enumName enumValueName statements = map addValueToEnum' statements
where
addValueToEnum' (table@CreateEnumType { name, values }) | name == enumName =
table { values = values <> [enumValueName] }
addValueToEnum' statement = statement

0 comments on commit 7f34cac

Please sign in to comment.