Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry.startIdForScope is not a function for 1.24.0-beta3 #27

Merged

Conversation

paradoxxxzero
Copy link
Contributor

This commit atom/atom@9006d05 removes the inheritance from textmateRegistry and wrap it instead. startIdForScope and endIdForScope are not proxified hence that fix.

@sharedprophet sharedprophet merged commit d930a9e into digitallyserviced:master Jan 31, 2018
@paradoxxxzero
Copy link
Contributor Author

Could you release? (It's backward compatible)

@sharedprophet
Copy link
Collaborator

Yes, sorry. Been sick and my main computer is currently not working. I'll release it now.

@paradoxxxzero
Copy link
Contributor Author

No problem, get well soon.
(On a side note, I think the issue when the grammar is not always applied at start is back.)

@sharedprophet
Copy link
Collaborator

Hmm, I haven't had a problem with it. Do you have any idea what conditions might trigger it?

@paradoxxxzero
Copy link
Contributor Author

paradoxxxzero commented Feb 6, 2018

Using the 1.24.0-beta3 and having lot of open tabs some open tabs.

My TextEditors have the NullGrammar. I'm going to look into what's happening.

@paradoxxxzero
Copy link
Contributor Author

Ok this is a conflict with language-babel, only happen on jsx files. I'll investigate some more.

@paradoxxxzero
Copy link
Contributor Author

Okay forget it it's worse than that, it seems something broke on the grammar initialisation level in the beta. I'm getting the problem on a fresh atom installation (without semanticolor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants