Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules: upgrade k8s.io/client-go to kubernetes-1.16.2 #68

Merged
merged 1 commit into from Nov 20, 2019
Merged

modules: upgrade k8s.io/client-go to kubernetes-1.16.2 #68

merged 1 commit into from Nov 20, 2019

Conversation

bengadbois
Copy link
Contributor

@bengadbois bengadbois commented Nov 18, 2019 •
edited

Done via

GO111MODULE=on go get k8s.io/client-go@kubernetes-1.16.2
GO111MODULE=on go mod tidy
GO111MODULE=on go mod vendor

adamwg
adamwg approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@adamwg adamwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@varshavaradarajan Any concerns about merging this? We might want to do some basic testing and make sure it works on all our current DOKS versions, but I can't think of any reason it wouldn't.

@varshavaradarajan
Copy link
Collaborator

Thanks for the PR, @bengadbois! Merging now. We'll make a new release later this week!

@varshavaradarajan varshavaradarajan merged commit 73f0904 into digitalocean:master Nov 20, 2019
@bengadbois bengadbois deleted the client-go-1.16.2 branch November 21, 2019 15:23
@varshavaradarajan varshavaradarajan mentioned this pull request Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwg adamwg adamwg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bengadbois @varshavaradarajan @adamwg