csi: fix incosistent driver name usages #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our driver name has changed from `com.digitalocean.csi.dobs` to `dobs.csi.digitalocean.com` because of the upcoming changes to the CSI spec that decided to follow a forward domain notation instead of reverse domain notation. Seems like the names were incorrect in many places and we also forget to update it in various places. I made sure to export `driver.DriverName` and use that variable everywhere in the code. So in the future, if we need to change it again, we'll make sure it's updated correctly from a single place.
bouk
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our driver name has changed from
com.digitalocean.csi.dobstodobs.csi.digitalocean.combecause of the upcoming changes to the CSIspec that decided to follow a forward domain notation instead of reverse
domain notation.
Seems like the names were incorrect in many places and we also forget to
update it in various places. I made sure to export
driver.DriverNameand use that variable everywhere in the code. So in the future, if we
need to change it again, we'll make sure it's updated correctly from a
single place.