Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor waitAction #229

Merged
merged 1 commit into from Dec 10, 2019
Merged

Refactor waitAction #229

merged 1 commit into from Dec 10, 2019

Commits on Dec 9, 2019

  1. Refactor waitAction

    This change refactors waitAction to use wait.PollUntil from the upstream
    apimachinery library to hide the underlying polling infrastructure and
    simplify the implementation.
    
    We also exit the method if the context got cancelled while waiting for a
    response from the volume API. Previously, we would iterate through the
    for loop once again and possibly do another unnecessary API interaction
    if the ticker was ready again by that time.
    
    Finally, we add a unit test (which required making the wait action
    timeout injectable).
    timoreimann committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    8d01c7a View commit details
    Browse the repository at this point in the history