Make volumes page size customizable #431
Merged
+92
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in support for accounts having a large number of volumes, allowing periodic resyncs through the csi-attacher to become more efficient and less heavy in terms of number of API calls needed. We also stop showing all volumes listed since that also has the potential to clutter the logs on accounts with many volumes.
timoreimann
force-pushed
the
increase-volumes-paging-efficiency
branch
from
b03170f
to
188de0e
Compare
varshavaradarajan
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support for accounts having a large number of volumes, allowing periodic resyncs through the csi-attacher to become more efficient and less heavy in terms of number of API calls needed.
We also stop showing all volumes listed since that also has the potential to clutter the logs on accounts with many volumes.