Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s deps to 1.25 #461

Merged
merged 10 commits into from Nov 1, 2022
Merged

Update k8s deps to 1.25 #461

merged 10 commits into from Nov 1, 2022

Conversation

varshavaradarajan
Copy link
Collaborator

Really nice instructions in the tests/e2e/README.md! Thank you!

Makefile Show resolved Hide resolved
test/e2e/testdrivers/1.25.yaml Show resolved Hide resolved
test/e2e/Dockerfile Outdated Show resolved Hide resolved
@mo-rieger
Copy link
Contributor

Hmm, for some reason, ginkgo tests immediately time out after the cluster is provisioned....digging into it

@varshavaradarajan
Copy link
Collaborator Author

@mo-rieger : onsi/ginkgo#1054

@varshavaradarajan varshavaradarajan force-pushed the varsha/update-k8s-deps branch 2 times, most recently from 63d0263 to a16cac7 Compare October 28, 2022 01:32
Copy link
Collaborator

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question, otherwise good.

test/e2e/Dockerfile Show resolved Hide resolved
Copy link
Collaborator

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we can get the tests to pass.

@varshavaradarajan
Copy link
Collaborator Author

I squashed commits and amended the last commit on the last push too quickly. Will rerun after a while.

@varshavaradarajan varshavaradarajan merged commit 33077d2 into master Nov 1, 2022
@varshavaradarajan varshavaradarajan deleted the varsha/update-k8s-deps branch November 1, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants