Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LBs does not account for nodes using IPs as node names #69

Closed
andrewsykim opened this issue Mar 31, 2018 · 3 comments
Closed

LBs does not account for nodes using IPs as node names #69

andrewsykim opened this issue Mar 31, 2018 · 3 comments

Comments

@andrewsykim
Copy link
Contributor

When we add droplets to LBs we only check if the node name matches the droplet names, however, it's common for droplets to be named after their public/private IPs so it should check for that as well. Here's where the check is https://github.com/digitalocean/digitalocean-cloud-controller-manager/blob/master/do/loadbalancers.go#L259.
@klausenbusk
Copy link
Contributor

klausenbusk commented Apr 6, 2018 •
edited

This #75 fix the bug, but it add a lot of overhead.. I should redo the PR..

@andrewsykim
Copy link
Contributor Author

andrewsykim commented Apr 6, 2018 •
edited

Yeah, seems like you can compare the node's name with the droplet's private IP instead of calling dropletByName again

@klausenbusk
Copy link
Contributor

Could you take a look again?

@klausenbusk klausenbusk mentioned this issue Apr 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@klausenbusk @andrewsykim