loadbalancers: Support nodes where nodeName is the private or public IP

[klausenbusk]

Fix #69

[andrewsykim]

Could we handle this error here?

[klausenbusk]

I think we should only log it for now or change the nodeAddresses function, right now a single node without private network would cause a error. Why do we require private network anyway? It should be optional.

digitalocean-cloud-controller-manager/do/droplets.go

Lines 75 to 92 in 5761801

	func nodeAddresses(droplet *godo.Droplet) ([]v1.NodeAddress, error) {
	var addresses []v1.NodeAddress
	addresses = append(addresses, v1.NodeAddress{Type: v1.NodeHostName, Address: droplet.Name})
	privateIP, err := droplet.PrivateIPv4()
	if err != nil || privateIP == "" {
	return nil, fmt.Errorf("could not get private ip: %v", err)
	}
	addresses = append(addresses, v1.NodeAddress{Type: v1.NodeInternalIP, Address: privateIP})
	publicIP, err := droplet.PublicIPv4()
	if err != nil || publicIP == "" {
	return nil, fmt.Errorf("could not get public ip: %v", err)
	}
	addresses = append(addresses, v1.NodeAddress{Type: v1.NodeExternalIP, Address: publicIP})
	return addresses, nil
	}

We do not handle error in

digitalocean-cloud-controller-manager/do/droplets.go

Line 206 in 5761801

addresses, _ := nodeAddresses(&droplet)

either.

[andrewsykim]

That is very reasonable, just logging works for me :)

[andrewsykim]

@klausenbusk thanks so much for this PR. Just had one minor comment and it should good to go

[klausenbusk]

Ready for merge I suppose. I'm not sure if I did the logging thing correctly (?).

[andrewsykim]

There should be a continue here otherwise there would be a panic on the next for loop

[klausenbusk]

Done, are you sure about the panic? The spec says For a nil slice, the number of iterations is 0.

[andrewsykim]

TIL :)

[andrewsykim]

sorry @klausenbusk one more comment

[andrewsykim]

LGTM thanks!