Add the ability to overide the DO API address. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitschysynq
approved these changes
Apr 23, 2018
|
lgtm |
andrewsykim
reviewed
Apr 23, 2018
do/cloud.go
Outdated
| doClient := godo.NewClient(oauthClient) | ||
| doClient, err := godo.New(oauthClient, opts...) | ||
| if err != nil { | ||
| return nil, errors.New("failed to create godo client") |
There was a problem hiding this comment.
fmt.Errorf() to include the error in the return value
There was a problem hiding this comment.
Sure. Would you like me to do the same for the dropletRegion call?
|
lgtm, thanks for the clean up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.