Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all Kubernetes dependencies to v1.10.2 #93

Merged
merged 6 commits into from
May 9, 2018

Conversation

andrewsykim
Copy link
Contributor

@andrewsykim andrewsykim commented May 9, 2018

Notes:

  • in v1.10 all methods in the cloud provider interface now expect context.Context as the first argument. This requires us to import both go context and godo context :(
  • Cloud Controller Manager now uses component config so had to update main.go accordingly.
  • add override for --allow-untagged-cloud=true which allows CCM to run even though cluster ID is not set
  • updated godo to v1.2.0 which means we can use the context passed by the controller instead of using godo/context

@lxfontes
Copy link

lxfontes commented May 9, 2018

❤️

@fatih
Copy link
Contributor

fatih commented May 9, 2018

lgtm 👍

@andrewsykim
Copy link
Contributor Author

Forgot to run dep prune, much better now 😆

@bhcleek
Copy link
Contributor

bhcleek commented May 9, 2018

github.com/digitalocean/godo/context doesn't exist anymore. Instead of refactoring to use a package that's been removed from godo, why not just use the stdlib context package for all those functions to which you added context?

@andrewsykim
Copy link
Contributor Author

Ah, had no idea it was removed, I'll update it to use stdlib context, I much prefer that!

@bhcleek
Copy link
Contributor

bhcleek commented May 9, 2018

lgtm

@andrewsykim andrewsykim merged commit 0e41681 into digitalocean:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants