TS-1037 #64
Merged
TS-1037 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcb
reviewed
Dec 5, 2018
pkg/writer/sonar.go
Outdated
| err := s.client.Flush() | ||
| httpError, ok := err.(*tsclient.UnexpectedHTTPStatusError) | ||
| if !s.firstWriteSent && ok && httpError.StatusCode == 421 { | ||
| log.Errorf("This error can safely be ignored on startup: %s", err.Error()) |
There was a problem hiding this comment.
can you remove this line? We don't want an error message in this case.
When the do-agent restarts, it is likely that it'll send a metric faster than rate limitation will allow, resulting in a 429 error. This can safely be ignored. The code adjustment herein determines if the first response from a metric submission is an error with a status of 429. If so, it ignores it.
|
LGTM |
blockloop
reviewed
Dec 5, 2018
| if !s.firstWriteSent && ok && httpError.StatusCode == 429 { | ||
| err = nil | ||
| } | ||
| s.firstWriteSent = true |
There was a problem hiding this comment.
This is racey and should be wrapped in a sync.Once. Rather than using a boolean value (which is not thread safe). You should create a field on Sonar called onceIgnoreError sync.Once and you should change this block to be something like:
err := s.client.Flush()
s.onceIgnoreError.Do(func() {
httpError, ok := err.(*tsclient.UnexpectedHTTPStatusError)
if ok && httpError.StatusCode == 429 {
err = nil
}
})
return err
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the do-agent restarts, it is likely that it'll send a metric faster than rate limitation will allow, resulting in a 429 error. This can safely be ignored. The code adjustment herein determines if the first response from a metric submission is an error with a status of 429. If so, it ignores it.
Looking to extract the status code from the error in Flush here:
do-agent/pkg/clients/tsclient/client.go
Line 428 in d626f03