Fix clipboard write in heading_id hash links #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
What issue does this relate to?
cc #64
What should this PR do?
I had this stashed locally for #64 but never commited/pushed it -- the current functionality was meant to use
this.getAttribute('href')as part of manually composing the URL, but was then partially switched to usingthis.hrefresulting in the URL being duplicated.This PR fixes that functionality to fully switch to just using
this.href, which contains the fully composed/parsed URL for the anchor already.What are the acceptance criteria?
Clicking on a heading copies the correct URL to your clipboard.