Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually track loaded Prism components #74

Merged
merged 1 commit into from
May 11, 2023

Conversation

MattIPv4
Copy link
Member

Type of Change

  • Markdown-It Plugins: Prism

What issue does this relate to?

cc #69

What should this PR do?

Manually track what Prism components we've loaded, so that we don't repeatedly load components that don't directly load a new language (e.g. modifiers like js-templates that modifies javascript).

What are the acceptance criteria?

Modifier components aren't repeatedly loaded when a language that loads one is used in multiple code blocks.

For example, using typescript loads jsx which loads js-templates:

 ```ts
 console.log('test')
 ```

 ```ts
 console.log('test')
 ```

@MattIPv4 MattIPv4 added bug Something isn't working patch Change is SEMVER patch labels May 11, 2023
@MattIPv4 MattIPv4 merged commit 5895e28 into master May 11, 2023
@MattIPv4 MattIPv4 deleted the MattIPv4/fix-prism-loading branch May 11, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Change is SEMVER patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants