Allow logging for Prism to be toggled #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
What issue does this relate to?
N/A
What should this PR do?
Between the potential for component loading errors logging with the introduction of #69, and the potential for logging errors from bad Prism renders (keep HTML issues normally), logs can get quite noisy when rendering a lot of Markdown.
This PR adds a new option to the Prism plugin to toggle logging for errors, with the default being off. This is a change in the default behaviour, but one I feel still falls under the umbrella of a minor change as the actual output and functionality of the plugin is unchanged.
What are the acceptance criteria?
When logging is enabled, any render errors will produce an error in console. When logging is disabled, any render errors will be suppressed.