Droplets can be created with user_data and private_networking #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbishop, there's a branch running right now that is going to be for v1.1 and I'd love to see these changes in there. This is the branch: https://github.com/digitalocean/droplet_kit/tree/update-droplet-kit Maybe we should rebase against that? |
rbishop
force-pushed
the
user-data-and-private-networking
branch
from
c27ab5b
to
a0c2b46
Compare
|
@bobbytables Ah, nice. I think I did what you were asking for. Let me know if it's not what you meant. |
|
Yup! Thank you! |
|
Hmm, might need another rebase, we can get this in today. |
* Add user_data attribute to Droplet resource and mapping * Add private_networking attribute to Droplet resource and mapping
rbishop
force-pushed
the
user-data-and-private-networking
branch
from
a0c2b46
to
1bf587d
Compare
|
Hey it looks like the |
|
😁 👍 |
ivanvanderbyl
added a commit
that referenced
this pull request
Nov 5, 2014
Droplets can be created with user_data and private_networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these features are awesome so I wanted to be able to access them from DropletKit.
Also, there are appears to be some failing tests on master. A lot of tests are expecting a
XXXResourcebut are gettingPaginatedResourceinstead. I didn't have a whole lot of time to investigate unfortunately.