Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: some misspellings in code #5

Closed
taotetek opened this issue Nov 13, 2019 · 1 comment
Closed

Problem: some misspellings in code #5

taotetek opened this issue Nov 13, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@taotetek
Copy link
Collaborator

taotetek commented Nov 13, 2019

From go report card:

Misspell Finds commonly misspelled English words

firebolt/message/kafkamessagewire.go
Line 11: warning: "Acknowleged" is a misspelling of "Acknowledge" (misspell)
firebolt/node/kafkaconsumer/consumermetrics_test.go
Line 14: warning: "commited" is a misspelling of "committed" (misspell)
Line 14: warning: "commited" is a misspelling of "committed" (misspell)
Line 58: warning: "commited" is a misspelling of "committed" (misspell)
Line 58: warning: "commited" is a misspelling of "committed" (misspell)
Line 64: warning: "commited" is a misspelling of "committed" (misspell)
Line 64: warning: "commited" is a misspelling of "committed" (misspell)
Line 70: warning: "commited" is a misspelling of "committed" (misspell)
Line 70: warning: "commited" is a misspelling of "committed" (misspell)
Line 76: warning: "commited" is a misspelling of "committed" (misspell)
Line 76: warning: "commited" is a misspelling of "committed" (misspell)
Line 87: warning: "commited" is a misspelling of "committed" (misspell)
Line 87: warning: "commited" is a misspelling of "committed" (misspell)
Line 106: warning: "commited" is a misspelling of "committed" (misspell)
Line 106: warning: "commited" is a misspelling of "committed" (misspell)
Line 106: warning: "commited" is a misspelling of "committed" (misspell)
firebolt/leader/leader.go
Line 120: warning: "conection" is a misspelling of "connection" (misspell)
firebolt/message/kafkamessagesender.go
Line 58: warning: "Acknowleged" is a misspelling of "Acknowledge" (misspell)
@jnadler jnadler added the good first issue Good for newcomers label Nov 13, 2019
jnadler pushed a commit that referenced this issue Nov 14, 2019
* Adjust spelling, Address linter warnings
@jnadler
Copy link
Contributor

jnadler commented Nov 14, 2019

closed by #8

@jnadler jnadler closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants