Support configurable bucket ranges for bulk_process_time Histogram #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
First time contributor, please let me know if this is an acceptable PR!
To address #45, I am proposing a set of changes which amount to:
elasticsearch
node type, related to Histogram bucket configuration, min, max, and count (matching the inputs ofprometheus.ExponentialBuckets
/prometheus.ExponentialBucketsRange
)+Inf
which is not as helpful when often timeouts are 🤏 just barely (by a few seconds, at most) over bulk-index-timeout-msUsing the defaults above, and assuming a 5000ms
bulk-index-timeout-ms
in unit testing, this PR results in the following buckets on my machine:0.01, 0.026826957952797256, 0.07196856730011518, 0.19306977288832497, 0.5179474679231209, 1.3894954943731366, 3.7275937203149367, 9.999999999999991