bugfix: Ignore paths filtering with file outside of paths #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
paths
is defined andignore_paths
is has the coverage of one more subdirectory ofpaths
, there can be a scenario where a pull request contains 2 files. The first file exists withinignore_paths
and the second file does not matchpaths
norignore_paths
. The expectation is no new resource version should be created, but since we match on the number of files in the pull request with the number of files matched by the ignore path (in our example 2 and 1 respectively), because2 != 1
, the earlier logic to ignore the pull request would not have been satisfied (hencecontinue
would not have been executed). Instead, we must also check that there are no files that exist after applying bothpaths
andignore_paths
filter.