Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove scripts/golint.sh, replace with built-in golint flag #103

Closed
mdlayher opened this issue Oct 4, 2016 · 0 comments · Fixed by #104
Closed

ci: remove scripts/golint.sh, replace with built-in golint flag #103

mdlayher opened this issue Oct 4, 2016 · 0 comments · Fixed by #104
Labels
ci hacktoberfest help wanted

Comments

@mdlayher
Copy link
Contributor

mdlayher commented Oct 4, 2016

golint has a flag that causes it to exit with non-zero status, rendering our CI build script for this purpose obsolete.

Replace with golint -set_exit_status ./... in CI.

This is an easy Hacktoberfest contribution, so I'll leave this unfixed for a few days. Feel free to submit a PR to fix this and work toward that t-shirt!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace scripts/golint.sh with built-in golint flag bronzdoc/go-qemu
1 participant
@mdlayher