Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expiry_seconds parameter on kubeconfig requests #334

Closed
andrewsomething opened this issue May 20, 2020 · 3 comments · Fixed by #382
Closed

Support expiry_seconds parameter on kubeconfig requests #334

andrewsomething opened this issue May 20, 2020 · 3 comments · Fixed by #382

Comments

@andrewsomething
Copy link
Member

andrewsomething commented May 20, 2020

The /v2/kubernetes/clusters/$K8S_CLUSTER_ID/kubeconfig endpoint supports an expiry_seconds query paramater:

https://developers.digitalocean.com/documentation/v2/#retrieve-the-kubeconfig-for-a-kubernetes-cluster

godo does not currently support passing that parameter:

func (svc *KubernetesServiceOp) GetKubeConfig(ctx context.Context, clusterID string) (*KubernetesClusterConfig, *Response, error) {

In order to keep the API stable for callers of the existing method, a new method should be added (e.g. GetKubeConfigWithExpiry).


This is to enable a doctl feature request. Adding here to track the needed work all the way through. See: digitalocean/doctl#791

@ivanlemeshev
Copy link
Contributor

Hey @andrewsomething I would like to do this issue

@andrewsomething
Copy link
Member Author

@ivanlemeshev Go for it! Don't hesitate to ask, if you have any questions.

andrewsomething added a commit that referenced this issue Oct 7, 2020
* Add GetKubeConfigWithExpiry (#334)

* Add expiry_seconds assert in test (#334)

Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>
@andrewsomething andrewsomething linked a pull request Oct 7, 2020 that will close this issue
@andrewsomething
Copy link
Member Author

Closed via #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants