Kubernetes: add taints field to node pool create and update requests #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisLaw
reviewed
Sep 21, 2020
| @@ -103,6 +119,7 @@ type KubernetesNodePoolUpdateRequest struct { | |||
| Count *int `json:"count,omitempty"` | |||
| Tags []string `json:"tags,omitempty"` | |||
| Labels map[string]string `json:"labels,omitempty"` | |||
| Taints *[]Taint `json:"taints,omitempty"` | |||
There was a problem hiding this comment.
Why do we need a pointer here? Just curious because I've noticed that the other structs have Taints []Taint.
There was a problem hiding this comment.
Great question. The pointer is needed here so that we can differentiate between taints being omitted on the update (meaning "I do not want to change the taints at all in my update request") and setting the empty (not nil) slice (meaning "I want to clear all taints").
Taints on the other structs are not pointerized because in the respective cases, there is no need to:
- for the create request in
KubernetesNodePoolCreateRequest, not setting the taints is equal to leaving the taints empty, so no pointer is needed. - the
KubernetesNodePoolstruct is returned from the API and is meant to indicate which taints are set. We want to be able to indicate if DOKS uses have zero or more taints set, so again no pointer is needed.
Hope this helps.
This change adds support for persistent node pool taints, a feature in DOKS to associate Kubernetes taints with current and future nodes of a pool.
timoreimann
force-pushed
the
add-support-for-kubernetes-node-pool-taints
branch
from
82e120c
to
1c8fe6b
Compare
Verolop
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for persistent node pool taints, a feature in DOKS to associate Kubernetes taints with current and future nodes of a pool.
Refs digitalocean/DOKS#3