Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Keep background color on connected interfaces for instant recognition #1303

Closed
traveler3468 opened this issue Jun 28, 2017 · 6 comments
Labels
type: feature Introduction of new functionality to the application

Comments

@traveler3468
Copy link

I was thinking that when you connected an interface the background color would stay green. When the page is reloaded the green color goes away. If you add this code to the interface.html file it will keep the green color on the connected interfaces. So when you load a device page page you can just glance at the page without having to read anything and see which interfaces have something connected(Green), which have planned connections (Blue) and which are open interfaces (White)

what it currently is:
<tr class="interface{% if iface.connection and not iface.connection.connection_status %} info{% endif %}">

What I changed it to to show the green for connected interfaces:
<tr class="interface{% if iface.connection and iface.connection.connection_status %} success{% endif %}{% if iface.connection and not iface.connection.connection_status %} info{% endif %}">

@cslingerland
Copy link

This would be awesome!

@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Jun 28, 2017
@bellwood
Copy link
Contributor

@traveler3468 would this styling assertion be valuable elsewhere, power, etc?

UI consistency is key =)

@jeremystretch if you're open to PR's on this one I'd be glad to help - just want to make sure we're on the same page for where this would be applicable.

@traveler3468
Copy link
Author

@bellwood My thought here is that any easily recognizable information is better for users than having to look further into something if its not necessary. Obviously if you're looking for more specific information then you are going to look harder for it. I think that if this kind of styling could be applicable anywhere where that kind of "easy to see" differentiation would be helpful.

@Zorlin
Copy link

Zorlin commented Jun 29, 2017

Massive +1, this could be a huge improvement.

@jeremystretch
Copy link
Member

To be clear, you just want to see connected interfaces always highlighted in green? And keep the blue highlighting for those in the "planned" state?

@traveler3468
Copy link
Author

Correct. That way when looking at a device page it is easily recognizable which interfaces are free(nothing connected or planned) and which interfaces either A: Have something connected and, B: Have a planned connection.

lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

5 participants