PyCrypto is dead; Use cryptodome

[jdell64]

Issue type

[ ] Feature request
[X] Bug report
[ ] Documentation

Environment

• Python version: 3.6.2
• NetBox version: Example: 2.1.3

Description

To replicate, attempt to run this on a windows server / windows box. pcrypto won't install and is dead now. replacing it with pycryptodome gets you further in the process, but fails when referencing XOR

[jdell64]

Additionally,

https://docs.openstack.org/bandit/latest/blacklists/blacklist_calls.html#b304-b305-ciphers-and-modes

states that Crypto.Cipher.XOR.new is insecure.

[jdell64]

Opened a PR #1528

I don't know enough about what the XOR function is doing to replace it properly

[jdell64]

opened a new PR #1531

[jeremystretch]

Was this issue opened to address a bug? If so, please file a bug report using the issue template. Otherwise, these changes do not appear to be necessary.

[jdell64]

I'll fill out the form. The two issues it addresses is is that

1. it won't run on windows because pyCrypto will not install on windows. The only way to make this work is to install packages defunct for 3 years and downgrade to a python version that is no longer supported.

2. pcrypto is dead. The application makes heavy use of some functions in there that have been dropped from it's replacement pycryptodome

[jdell64]

I have a monkey patch that works (passes the cibuild). Should I raise another PR or just let you review it in my fork? (link: https://github.com/jdell64/netbox)

[jdell64]

Thanks for all your hard work on this 👍