Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export: add field value delimiter to string fields #764

Closed
Armadill0 opened this issue Jan 3, 2017 · 4 comments
Closed

Export: add field value delimiter to string fields #764

Armadill0 opened this issue Jan 3, 2017 · 4 comments
Assignees
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@Armadill0
Copy link

Armadill0 commented Jan 3, 2017

If you export data and reimport it and there are description fields containing commas, those would lead to wrong data imports.

On fields which can contain user defined strings, it would be great to have a double quote field value delimiter, to avoid such problems. This is also covered by the CSV RFC: https://tools.ietf.org/html/rfc4180 (paragraph 2.5 and 2.6)

@jeremystretch
Copy link
Member

it would be great to have a double quote field value delimiter, to avoid such problems.

This has already been implemented (#422). Have you found a specific area where it isn't working?

@Armadill0
Copy link
Author

Armadill0 commented Jan 3, 2017

I explicitly found it for "Role" of the Prefixes export. I'll have a look in my other exports tomorrow if there are more occurences.

@jeremystretch
Copy link
Member

Oh my mistake, I was only looking at import. Yeah, we can add this to the to_csv() method on models with export capability.

@jeremystretch jeremystretch added the type: bug A confirmed report of unexpected behavior in the application label Jan 3, 2017
@Armadill0
Copy link
Author

Great, thanks! 😄

@jeremystretch jeremystretch self-assigned this Jan 3, 2017
lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants