Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow independent scrolling in split-column mode #433

Merged
merged 5 commits into from
Jun 12, 2023

Conversation

maskeynihal
Copy link
Contributor

Type of Change

  • Something else: Add independent scrolling

What issue does this relate to?

resolves #430

What should this PR do?

  • Add style overflowY: auto and height: 100vh for each column so that it can be scrolled horizontally.

What are the acceptance criteria?

  • Independent scrolling should be allowed for each column on Side-by-side mode.

Before

Before.independent.scroll.mov

After

Independent.scroll.mov

@MattIPv4 MattIPv4 self-requested a review June 2, 2023 21:55
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could we apply this styling in the SCSS, rather than mixing inline styles with classes?

@MattIPv4 MattIPv4 changed the title add left and right column scroll independently Allow independent scrolling in split-column mode Jun 5, 2023
@maskeynihal
Copy link
Contributor Author

@MattIPv4 What should we do for "Back to top" button?

@maskeynihal maskeynihal requested a review from MattIPv4 June 6, 2023 17:52
@MattIPv4
Copy link
Member

MattIPv4 commented Jun 7, 2023

What should we do for "Back to top" button?

Good question -- what do you think would be the best UX? I'm thinking it should scroll the document, and both the columns, back to the top?

@maskeynihal
Copy link
Contributor Author

@MattIPv4 I have updated the copyright year to 2023.

Should I update the copyright year on every file of the whole repo?

@maskeynihal
Copy link
Contributor Author

What should we do for "Back to top" button?

Good question -- what do you think would be the best UX? I'm thinking it should scroll the document, and both the columns, back to the top?

Yes, that sounds right. Should I do that in this PR or in another PR?

@maskeynihal maskeynihal requested a review from MattIPv4 June 8, 2023 17:32
@MattIPv4
Copy link
Member

MattIPv4 commented Jun 8, 2023

Should I update the copyright year on every file of the whole repo?

Only the files you have touched in this PR, please

Yes, that sounds right. Should I do that in this PR or in another PR?

It'd be great to do it in this PR, please, as it's related to the change being made here

@maskeynihal
Copy link
Contributor Author

@MattIPv4 I have updated the code. Now, the independent column also scrolls when "Back to top" is clicked.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty

@MattIPv4 MattIPv4 merged commit 5b8e0bc into digitalocean:master Jun 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wider content and sticky or similiar right column behavior on side by side mode
2 participants