Skip to content

Commit

Permalink
Fix panics introduced in move from ReadFunc to ReadContextFunc (#506)
Browse files Browse the repository at this point in the history
* resourceDigitalOceanCDNRead: return nil on success (Closes: #505).

* resourceDigitalOceanAppRead: return nil on success.
  • Loading branch information
andrewsomething committed Oct 22, 2020
1 parent a1f8c4d commit 295deb7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions digitalocean/resource_digitalocean_app.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ package digitalocean
import (
"context"
"fmt"
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"log"
"time"

"github.com/hashicorp/terraform-plugin-sdk/v2/diag"

"github.com/digitalocean/godo"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)
Expand Down Expand Up @@ -115,7 +116,7 @@ func resourceDigitalOceanAppRead(ctx context.Context, d *schema.ResourceData, me
return diag.Errorf("[DEBUG] Error setting app spec: %#v", err)
}

return diag.FromErr(err)
return nil
}

func resourceDigitalOceanAppUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
Expand Down
2 changes: 1 addition & 1 deletion digitalocean/resource_digitalocean_cdn.go
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func resourceDigitalOceanCDNRead(ctx context.Context, d *schema.ResourceData, me
d.Set("certificate_name", cert.Name)
}

return diag.FromErr(err)
return nil
}

func resourceDigitalOceanCDNUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
Expand Down

0 comments on commit 295deb7

Please sign in to comment.