Simplified some loops based on go-staticcheck S1011 #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More details about the pattern are given in https://staticcheck.io/docs/checks#S1011
|
@scotchneat @andrewsomething Maybe you can also take a look at this. It's less "controversial" than #657 |
scotchneat
approved these changes
Jul 13, 2021
benwebber
added a commit
to benwebber/terraform-provider-digitalocean
that referenced
this pull request
Oct 3, 2021
Fixes regression introduced in 35e97db. See-also: 35e97db (Simplified some loops based on go-staticcheck S1011 (digitalocean#656), 2021-07-13)
andrewsomething
pushed a commit
that referenced
this pull request
Oct 4, 2021
atombrella
pushed a commit
to atombrella/terraform-provider-digitalocean
that referenced
this pull request
Oct 10, 2021
Fixes regression introduced in 35e97db. See-also: 35e97db (Simplified some loops based on go-staticcheck S1011 (digitalocean#656), 2021-07-13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details about the pattern are given in https://staticcheck.io/docs/checks#S1011
I found the matches with
staticcheck . | grep S1011inside the digitalocean directory.Edit: Same with S1031.