Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose TTL in digital_ocean.domain. #702

Merged
merged 2 commits into from Sep 21, 2021
Merged

Expose TTL in digital_ocean.domain. #702

merged 2 commits into from Sep 21, 2021

Conversation

atombrella
Copy link
Contributor

No description provided.

andrewsomething
andrewsomething reviewed Sep 21, 2021
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add a line to the resource docs for it?

https://github.com/digitalocean/terraform-provider-digitalocean/blob/main/docs/resources/domain.md#attributes-reference

@atombrella
Copy link
Contributor Author

Looks good! Can you add a line to the resource docs for it?

https://github.com/digitalocean/terraform-provider-digitalocean/blob/main/docs/resources/domain.md#attributes-reference

Done.

scotchneat
scotchneat approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@scotchneat scotchneat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution @atombrella

@scotchneat scotchneat merged commit ebaf9f7 into digitalocean:main Sep 21, 2021
@atombrella atombrella deleted the data_domain_ttl_test branch September 22, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething left review comments

@scotchneat scotchneat scotchneat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atombrella @andrewsomething @scotchneat