Add HA support to digitalocean_kubernetes_cluster #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the `ha` boolean attribute when creating Kubernetes clusters.
Sets the `ForceNew` option on the new HA attribute to prevent it from being set on updates. Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>
ChiefMateStarbuck
previously approved these changes
Oct 6, 2021
atombrella
reviewed
Oct 7, 2021
Adds a separate acceptance test for HA clusters due to the fact the 1.21 clusters currently have different functionality in terms of exposing an endpoint and IPv4 address than the 1.19. Also adds a note to the docs about cluster re-creation on updates that use the HA field.
…alocean/terraform-provider-digitalocean into bentranter/doks-ha-support
andrewsomething
approved these changes
Oct 7, 2021
|
Hi 👋🏻 Is there somewhere I can read about this feature? |
atombrella
pushed a commit
to atombrella/terraform-provider-digitalocean
that referenced
this pull request
Oct 10, 2021
* Add HA support to digitalocean_kubernetes_cluster Adds support for the `ha` boolean attribute when creating Kubernetes clusters. * Set ForceNew on HA option Sets the `ForceNew` option on the new HA attribute to prevent it from being set on updates. Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com> * Add acceptance test for HA clusters Adds a separate acceptance test for HA clusters due to the fact the 1.21 clusters currently have different functionality in terms of exposing an endpoint and IPv4 address than the 1.19. Also adds a note to the docs about cluster re-creation on updates that use the HA field. Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>
|
@46bit Hi, yes, we have a release announcement here https://www.digitalocean.com/blog/new-control-plane-digitalocean-managed-kubernetes/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
haboolean attribute when creating Kubernetes clusters.Also bumps the version of godo to the latest release.