Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

databases: Provide better error messages importing sub-resources. #744

Merged
merged 1 commit into from Nov 8, 2021

Conversation

andrewsomething
Copy link
Member

Some database cluster sub-resources (e.g. users) require passing the ID of the cluster and the name of the sub-resource joined with a comma when importing. This PR provide more helpful error messaging if the argument is not comma separated.

Fixes: #743

@andrewsomething andrewsomething requested a review from a team November 8, 2021 15:46
@andrewsomething andrewsomething temporarily deployed to Acceptance Tests November 8, 2021 15:47 Inactive
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewsomething andrewsomething merged commit f9fa72b into main Nov 8, 2021
@andrewsomething andrewsomething deleted the asb/issues/743 branch November 8, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messages for importing existing dbs and users
2 participants