apps: Support functions components. #831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support functions components to the app resource and data source.
The new acceptance test creates an app with a functions component and then updates it by adding a CORs configuration. The update was triggering an infinite loop as the in-progress deployment completes before we poll the app to find it. I've fixed this with an approach like what we are now doing in doctl (digitalocean/doctl#1143). I've left comments around why this fix is not ideal, but after conversations with the Apps team for the doctl issue, it is currently the best solution. Unfortunately, it actually looks like we missed reviewing a PR attempting to fix this (#818) previously.