Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary: DPR analysis results are always shown in the bottom pane. This is not consistent with DPRv1 #77

Closed
parthopdas opened this issue Feb 17, 2020 · 5 comments
Assignees

Comments

@parthopdas
Copy link
Member

parthopdas commented Feb 17, 2020

[Split from #53]
4. To be discussed: DPR analysis results are always shown in the bottom pane. This is not consistent with DPRv1 where sometimes - depending on the context - results are shown in the main pane. However this was for me a way to quickly establish this functionality, as there were two divs with identical id divb which caused trouble, and I renamed one of them to divb2.

This must be also covered by this issue (was tracked by #53):
When doing a PED, DPPN or CPED, or combined term search and then clicking on a term, the bottom frame should open if it's closed, but doesn't. It should automatically open. Alternatively, the results should be displayed in the main frame instead of the bottom frame.

@dangeol
Copy link
Collaborator

dangeol commented Feb 22, 2020

Can we move this discussion to beta?

@parthopdas
Copy link
Member Author

Can we move this discussion to beta?
Hi @dangeol IMO we should keep this for alpha as this is a parity issue. i.e. users will be expecting something in dprweb but finding something else. In addition currently this appears in the bottom pane which does not expand by default - so that is further confusing.

let me know what you think.

@parthopdas parthopdas self-assigned this Feb 23, 2020
@dangeol
Copy link
Collaborator

dangeol commented Feb 23, 2020

Ok. The issue that the bottom pane does not expand when clicking on terms will be covered by #53. This was marked as alpha in the spreadsheet, but not here until yesterday. Sorry for that.

parthopdas added a commit that referenced this issue Feb 26, 2020
parthopdas added a commit that referenced this issue Feb 26, 2020
parthopdas added a commit that referenced this issue Feb 26, 2020
@parthopdas
Copy link
Member Author

@shraddha314 this should be fixed now. please let me know if you require clarification.

@dangeol
Copy link
Collaborator

dangeol commented Feb 26, 2020

Clicking on words in the text for DPR Analysis does not show content in bottom frame.

@dangeol dangeol reopened this Feb 26, 2020
parthopdas added a commit that referenced this issue Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants